Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(fileuploaderbutton): remove unused listFiles prop #9915

Merged
merged 3 commits into from
Oct 21, 2021
Merged

chore(fileuploaderbutton): remove unused listFiles prop #9915

merged 3 commits into from
Oct 21, 2021

Conversation

tay1orjones
Copy link
Member

Closes #9894

Removes an unused listFiles prop that was being spread onto a DOM element, causing errors from React DOM.

Changelog

Removed

  • fileuploaderbutton: remove unused listFiles prop

@tay1orjones tay1orjones requested a review from a team as a code owner October 20, 2021 22:00
@tay1orjones tay1orjones requested a review from a team as a code owner October 20, 2021 22:15
@netlify
Copy link

netlify bot commented Oct 20, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 139af08

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6171bb6a94f1b6000827ddeb

😎 Browse the preview: https://deploy-preview-9915--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 20, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 139af08

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6171bb6a22b31300070bd8cc

😎 Browse the preview: https://deploy-preview-9915--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Oct 20, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 139af08

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6171bb6a0abe150008355bfe

😎 Browse the preview: https://deploy-preview-9915--carbon-elements.netlify.app

@kodiakhq kodiakhq bot merged commit f012e36 into carbon-design-system:main Oct 21, 2021
@kevinsperrine kevinsperrine mentioned this pull request Nov 9, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: FileUploaderButton's listFiles prop is forwarded to DOM element
3 participants
@tay1orjones @sstrubberg @jnm2377